Repository navigation
chore(sql): version the SQL files and test their examples - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL files shipped with no version, so a database could not tell which copy it had loaded, and their README examples were only checked by hand.
ng_postcode_version(). The conformance run checks that the two agree.scripts/sql_conformance.py postgresnow also runs every SQL block insql/README.md, in order, in a transaction that is rolled back. I confirmed it fails when an example is broken.docs/group-by-place.mdruns as a test in the Python suite.sql-v*tag checks that the tag is onmainand matches the version in both files, reruns the conformance cases on both engines, and attaches the two files to a GitHub release. Nothing goes to a registry.No new CI jobs: the checks ride on steps that already exist.